Modernize packaging and fix CI #130
Open
+35
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
reviewed
Oct 7, 2025
| "Environment :: Web Environment", | ||
| "Development Status :: 5 - Production/Stable", | ||
| ] | ||
| requires-python = ">=3.8" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
I think these days there's no need to have an optional dependency on Cython. You can declare cython as a build dependency in your
pyproject.tomland pip or uv will install Cython in the build environment.I make use of that capability to substantially simplify the
setup.pyfile.Since creating a
pyproject.tomlfile automatically opts into pep 517 isolated builds, I also took the opportunity to move all the static metadata intopyproject.toml.I probably also need to update the makefile and readme but I didn't want to do that without confirming that this approach is OK with the maintainers.
To get the CI to pass I also had to drop Python 3.8 support. Python 3.8 has been EOL since October 2024.