Skip to content

really drop python<=3.7 support #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

really drop python<=3.7 support #608

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c0865
really drop python<=3.7 support
kloczek Jun 18, 2024
6653298
remove cede duplicated in pyprojest.tomil decalaration
kloczek Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import sys

vi = sys.version_info
if vi < (3, 8):
raise RuntimeError('uvloop requires Python 3.8 or greater')

Comment on lines -3 to -6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"requires-python = '>=3.8.0'" in pyproject.toml is enough.

I'd keep this extra check. For people who uses Python < 3.8, they may also have a pip around year 2016 or earlier, which doesn't honor requires-python.

if sys.platform in ('win32', 'cygwin', 'cli'):
raise RuntimeError('uvloop does not support Windows at the moment')

Expand Down