Standalone Viewer Package #91
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all viewer widgets and their windows into a new subpackage MPIViewers. This package does not depend on MPIMeasurements, only on the "pure" data handling packages such as FFTW, MPIFiles, MPIReco and MPISphericalHarmonics.
The PR also adds the 3D data viewer is it is based on that.
This mean this PR requires latest Gtk4 for Gtk4Makie and to connect MPIUI and MPIViewers we require the [sources] section from Julia 1.11 Project.tomls.
Known issues are:
Before merging we should finish up the MPIMeasurements merge + related GUI update (mainly sequence ui elements + @jusack MPIUI branch) and any other open branches like the MagneticFieldViewer. Afterwards we can manually "move" the relevant code pieces to MPIViewers