Option to add timestamps to the .txt file output.#355
Option to add timestamps to the .txt file output.#355cbsfletch wants to merge 2 commits intoMahmoudAshraf97:mainfrom
Conversation
In the command line to diarize.py or diarize-parallel, simply include --with-txt-timestamps Default is false
In the command line to diarize.py or diarize-parallel, simply include --with-txt-timestamps Default is false
Summary of ChangesHello @cbsfletch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the diarization scripts by adding an optional feature to include timestamps in the plain text output files. This allows users to generate transcripts with temporal markers for each speaker's turn, improving the utility and readability of the output for applications requiring precise timing information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new command-line option, --with-txt-timestamps, to add timestamps to the .txt output files in both diarize.py and diarize-parallel.py. The implementation in helpers.py correctly adds a timestamp whenever the speaker changes. The overall logic is sound. My feedback is focused on improving the clarity of the help text for the new argument to ensure users understand exactly when timestamps are added.
| "--with-txt-timestamps", | ||
| action="store_true", | ||
| dest="txt_timestamps", | ||
| help="Include timestamps in the txt file output. This argument is optional, and by default timestamps are not included in the txt output.", |
There was a problem hiding this comment.
The help text is a bit verbose and could be more precise. The current implementation adds timestamps only when the speaker changes. The current description might imply that every sentence gets a timestamp. Updating the help text to reflect this behavior will improve clarity for users.
| help="Include timestamps in the txt file output. This argument is optional, and by default timestamps are not included in the txt output.", | |
| help="Include timestamps in the txt file output at speaker changes.", |
| "--with-txt-timestamps", | ||
| action="store_true", | ||
| dest="txt_timestamps", | ||
| help="Include timestamps in the txt file output. This argument is optional, and by default timestamps are not included in the txt output.", |
There was a problem hiding this comment.
The help text is a bit verbose and could be more precise. The current implementation adds timestamps only when the speaker changes. The current description might imply that every sentence gets a timestamp. Updating the help text to reflect this behavior will improve clarity for users.
| help="Include timestamps in the txt file output. This argument is optional, and by default timestamps are not included in the txt output.", | |
| help="Include timestamps in the txt file output at speaker changes.", |
In the command line to diarize.py or diarize-parallel, simply include --with-txt-timestamps
Default is false