Skip JS preload hints when load-on-intent mode is active#622
Merged
Conversation
The minification helper sends Link: rel=preload HTTP headers for every JS file, which instructs the browser to download scripts immediately. This defeats the purpose of the load-on-intent defer mode, which is designed to delay both downloading and execution until user interaction.
load-on-intent mode is active
fballiano
commented
Mar 4, 2026
Contributor
Author
fballiano
left a comment
There was a problem hiding this comment.
Minor style nit: the two nested if statements could be a single condition with &&:
if ($as === 'script'
&& (int) Mage::getStoreConfig('dev/js/defer_mode') === Mage_Core_Model_Source_Js_Defer::MODE_LOAD_ON_INTENT
) {
return;
}PHP short-circuits &&, so getStoreConfig is still only called for script assets — same behavior, just cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendEarlyHint) sendsLink: rel=preload; as=scriptHTTP headers for every JS file during head renderingtype="text/plain"load-on-intent deferral mechanismTest plan