Skip to content

fix/4142/node-modules-not-excluded#4149

Merged
Nereboss merged 2 commits intomainfrom
fix/4142/node-modules-not-excluded
Aug 7, 2025
Merged

fix/4142/node-modules-not-excluded#4149
Nereboss merged 2 commits intomainfrom
fix/4142/node-modules-not-excluded

Conversation

@Nereboss
Copy link
Collaborator

@Nereboss Nereboss commented Aug 6, 2025

Fix exclude pattern not correctly working for direct children of project root

Closes: #4142

Description

Due to a bug all exclude patterns that started with a '/' did not apply to direct subfolders of the folder that CodeCharta was called on. This PR fixes this and adds a test for exclude patterns

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

@Nereboss Nereboss merged commit 0be1998 into main Aug 7, 2025
5 checks passed
@Nereboss Nereboss deleted the fix/4142/node-modules-not-excluded branch August 7, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unifiedparser: node_modules should also be excluded by default

2 participants