Skip to content

[flutter_appauth] Fix exception: login hint must not empty if hint empty in android #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[flutter_appauth] Fix exception: login hint must not empty if hint empty in android #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions flutter_appauth_platform_interface/lib/src/authorization_request.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import 'common_request_details.dart';
import 'external_user_agent.dart';

/// The details of an authorization request to get an authorization code.
class AuthorizationRequest extends CommonRequestDetails
with AuthorizationParameters {
class AuthorizationRequest extends CommonRequestDetails with AuthorizationParameters {
AuthorizationRequest(
String clientId,
String redirectUrl, {
Expand All @@ -17,8 +16,7 @@ class AuthorizationRequest extends CommonRequestDetails
Map<String, String>? additionalParameters,
List<String>? promptValues,
bool allowInsecureConnections = false,
ExternalUserAgent externalUserAgent =
ExternalUserAgent.asWebAuthenticationSession,
ExternalUserAgent externalUserAgent = ExternalUserAgent.asWebAuthenticationSession,
String? nonce,
String? responseMode,
}) {
Expand All @@ -29,7 +27,12 @@ class AuthorizationRequest extends CommonRequestDetails
this.additionalParameters = additionalParameters;
this.issuer = issuer;
this.discoveryUrl = discoveryUrl;
this.loginHint = loginHint;
if (loginHint?.isEmpty == true) {
this.loginHint = null;
} else {
this.loginHint = loginHint;
}

this.promptValues = promptValues;
this.allowInsecureConnections = allowInsecureConnections;
this.externalUserAgent = externalUserAgent;
Expand Down