[flutter_appauth] fix: change presentingViewController to topMost viewController #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vity authorization result
…atch-appauth-activity-result [flutter_appauth] fix: rely on transparent IntentLauncherActivity to catch AppAuth activity result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppAuth Flutter plugin is currently using rootViewController as presentingViewController when it needs to present a ViewController (SafariVC) for authentication.
If there is some additional ViewController being presented on top of the root FlutterViewController, then the presentation will fail. In this case, using rootViewController will return the root, i.e. FlutterViewController, whose view is NOT in the window hierarchy because there is another viewController presented on top of it, then the system will raise the following error:
Attempt to present UIViewController on UIViewController whose view is not in the window hierarchy.
To avoid this issue, at any time, when needing to present a ViewController, we should instead retrieve and use the topMost viewController.