-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Windows unit tests no longer use the Windows SDK #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Levi-Lesches
wants to merge
5
commits into
MaikuB:master
Choose a base branch
from
Levi-Lesches:windows-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
746a7c2
Windows unit tests no longer use the Windows SDK
Levi-Lesches 5a6b816
Removed broken test
Levi-Lesches 79a32ba
Merge remote-tracking branch 'origin/master' into windows-tests
Levi-Lesches badf079
Removed global variable check, use DI instead
Levi-Lesches 26c6de7
Format
Levi-Lesches File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Just a mock, doesn't need real types or safety. | ||
| // ignore_for_file: type_annotate_public_apis, always_specify_types | ||
|
|
||
| import 'dart:ffi'; | ||
|
|
||
| import 'package:ffi/ffi.dart'; | ||
|
|
||
| import 'bindings.dart'; | ||
|
|
||
| /// Mocked FFI bindings. | ||
| class MockBindings implements NotificationsPluginBindings { | ||
| @override | ||
| void cancelAll(_) {} | ||
|
|
||
| @override | ||
| void cancelNotification(_, int id) {} | ||
|
|
||
| @override | ||
| Pointer<NativePlugin> createPlugin() => malloc<Int>().cast(); | ||
|
|
||
| @override | ||
| void disposePlugin(_) {} | ||
|
|
||
| @override | ||
| void freeLaunchDetails(_) {} | ||
|
|
||
| @override | ||
| void freeDetailsArray(ptr) => malloc.free(ptr); | ||
|
|
||
| @override | ||
| Pointer<NativeNotificationDetails> getActiveNotifications(_, __) => | ||
| malloc<NativeNotificationDetails>(); | ||
|
|
||
| @override | ||
| Pointer<NativeNotificationDetails> getPendingNotifications(_, __) => | ||
| malloc<NativeNotificationDetails>(); | ||
|
|
||
| @override | ||
| bool hasPackageIdentity() => false; | ||
|
|
||
| @override | ||
| bool init(_, __, ___, ____, _____, ______) => true; | ||
|
|
||
| @override | ||
| bool isValidXml(ptr) => true; | ||
|
|
||
| @override | ||
| bool scheduleNotification(a, b, c, d) => true; | ||
|
|
||
| @override | ||
| bool showNotification(a, b, c, d) => true; | ||
|
|
||
| @override | ||
| NativeUpdateResult updateNotification(a, b, c) => NativeUpdateResult.success; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 0 additions & 58 deletions
58
flutter_local_notifications_windows/test/bindings_test.dart
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you place this in the test folder? It's purely test related and is the approach taken when creating mocks via mocktail or mockito or hand crafted ones. Note this is also currently a stub not a mock. A mock provides the ability to record the interactions that can then be used to verify what took place. Can you also rename the class and adjust the docs accordingly to reflect this?