Implement tokio::AsyncWrite for EntryStreamWriter#160
Open
untitaker wants to merge 1 commit intoMajored:mainfrom
Open
Implement tokio::AsyncWrite for EntryStreamWriter#160untitaker wants to merge 1 commit intoMajored:mainfrom
untitaker wants to merge 1 commit intoMajored:mainfrom
Conversation
When creating entries, we cannot use Tokio to write file contents. Fix that.
Owner
|
The expected usage currently would be to use async-compat, like so: let mut writer = ZipFileWriter::with_tokio(Cursor::new(Vec::new()));
let entry = ZipEntryBuilder::new("test.txt".into(), Compression::Deflate);
let writer = writer.write_entry_stream(entry.build()).await.unwrap().compat_write();I know this isn't ideal, so I'm very much open to ideas of making the compatibility layer between the base implementation and tokio better. Will have a think about if we want to do it this way. |
Author
|
well, the other option i see is to make the writer generic over the inner writer, and expose a type alias like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating entries, we cannot use Tokio to write file contents. Fix
that.