Skip to content

Add a global event id#187

Merged
Lan2u merged 2 commits intomainfrom
add_global_event_id
Mar 28, 2026
Merged

Add a global event id#187
Lan2u merged 2 commits intomainfrom
add_global_event_id

Conversation

@Lan2u
Copy link
Copy Markdown
Collaborator

@Lan2u Lan2u commented Mar 28, 2026

The ability to have a global ordering of events is useful because it better lines up with the way the humans who use the system think. Having versions split by resources adds difficulty when an event spans multiple 'resources'. It also puts excess weight onto the selection of said resource -> an issue in an open source code base with differing maintainers over the years.

Global ordering can be a problem when working at a large distributed scale however:

  • it is extremely unlikely this system will ever deal with anything close to 'large'
  • even in large distributed systems having a notion of universal ordering is very useful because it better relates to how humans think. Mistakes in this global ordering can be corrected after the fact in a way that is much easier to reason about

We already effectively have a global ordering because of the rowid in sqlite however we are better to have our own indexed column for this rather than relying on an implementation detail -> particularly if we want to allow 'deleting' events.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 105a1815c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Lan2u Lan2u merged commit 82cd960 into main Mar 28, 2026
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Options to Done in Makespace Members App Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant