Skip to content

[codex] Pass dependencies to Command.process#190

Merged
Lan2u merged 3 commits intomainfrom
codex/pass-deps-to-command-process
Mar 29, 2026
Merged

[codex] Pass dependencies to Command.process#190
Lan2u merged 3 commits intomainfrom
codex/pass-deps-to-command-process

Conversation

@Lan2u
Copy link
Copy Markdown
Collaborator

@Lan2u Lan2u commented Mar 29, 2026

What changed

  • added a deps field to the Command.process input type
  • passed dependencies through applyToResource and the email verification landing page
  • added a focused regression test proving applyToResource forwards dependencies into Command.process
  • updated the shared test framework to provide full Dependencies when applying commands in tests

Why

Command.process previously only received the command payload and resource events, so commands had no access to the dependency bundle that already existed at the call sites. This change makes those dependencies available without forcing broad churn across existing direct process tests.

Impact

Commands invoked through the normal application flow can now read dependencies from input.deps inside Command.process.

Root cause

The dependency object stopped at the outer command application layer instead of being threaded into the command processor input.

Validation

  • npx jest tests/commands/apply-command-to-resource.test.ts
  • make test
  • make lint
  • make typecheck

@Lan2u Lan2u marked this pull request as ready for review March 29, 2026 19:34
@Lan2u Lan2u merged commit c6316d9 into main Mar 29, 2026
5 of 6 checks passed
@Lan2u Lan2u deleted the codex/pass-deps-to-command-process branch March 29, 2026 20:47
@github-project-automation github-project-automation bot moved this from Options to Done in Makespace Members App Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant