[codex] Pass dependencies to Command.process#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
depsfield to theCommand.processinput typeapplyToResourceand the email verification landing pageapplyToResourceforwards dependencies intoCommand.processDependencieswhen applying commands in testsWhy
Command.processpreviously only received the command payload and resource events, so commands had no access to the dependency bundle that already existed at the call sites. This change makes those dependencies available without forcing broad churn across existing directprocesstests.Impact
Commands invoked through the normal application flow can now read dependencies from
input.depsinsideCommand.process.Root cause
The dependency object stopped at the outer command application layer instead of being threaded into the command processor input.
Validation
npx jest tests/commands/apply-command-to-resource.test.tsmake testmake lintmake typecheck