Add Clustering Extension for dendrogram#5508
Draft
kescobo wants to merge 1 commit intoMakieOrg:masterfrom
Draft
Conversation
Member
|
Weak deps are still dependencies as far as dependency hell, update churn etc. are concerned. So I'm generally hesitant to add more to Makie. Would this fit as an extension to Clustering instead? |
Contributor
Author
|
Fair enough - I'd be happy to ask over there. I saw the one extension here so thought it might be worth it, but Makie def. has more deps than Clustering. That said, Clustering.jl hasn't had a commit merged in over a year, so not sure it's actively maintained. |
Contributor
Author
|
It could also be an option to just highlight the |
Contributor
Author
|
Well - that issue on Clustering.jl has not received any reply. Shall I just add this to the docs as an example? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends #2755 to add a package extension for the Clustering.jl
HClusttype. Draft still because I wasn't sure how (or if I should) add theuseheightparameter to enable usage of the heights in theHClust.Type of change
Checklist