Conversation
|
Hey @astariul , thanks for the PR, this is great! Currently the tests fail because pyrouge isn't found. Could you add it to the dependencies in setup.py please? |
|
I need help on this one ^^ |
|
setting aside that travis complains about a memory error, if I run the tests locally I get a permission denied for the The next error that pops up is that the wordnet exceptions db file cannot be opened. It appears that this page suggests to [re]build this database to get things to work on windows. Our build server is on linux though, so that maybe the question is where the file is from? |
To fix #68 and to have official scores (compared to #69), official ROUGE script is added (through
pyrouge)Dependencies
pyrougepackage is used.libxml-parser-perlmight be needed : see this issue_I'm not sure how to add these dependencies in Travis, if someone could provide help here 👍 _
Notes
Implementation works great. However, a few notes :
compute_metrics. I think the performance are not impacted.Licence
There is issue with licence :
pyrougedidn't include the official script in their repo because the licence of the official script is unknown.To make nlg-eval easy to use I already included the official script. My opinion is :