Skip to content

Update kubevirt gem#15

Merged
agrare merged 1 commit intoManageIQ:masterfrom
miq-bot:openapi_generate
Mar 5, 2025
Merged

Update kubevirt gem#15
agrare merged 1 commit intoManageIQ:masterfrom
miq-bot:openapi_generate

Conversation

@miq-bot
Copy link
Member

@miq-bot miq-bot commented Mar 4, 2025

Update the kubevirt-sdk-ruby gem from the kubevirt openapi-spec https://github.com/kubevirt/kubevirt/tree/main/api/openapi-spec

@miq-bot miq-bot requested review from Fryguy and agrare as code owners March 4, 2025 17:47
@miq-bot miq-bot added the enhancement New feature or request label Mar 4, 2025
@miq-bot miq-bot changed the title Update Kubevirt Gem Update kubevirt gem Mar 4, 2025
@miq-bot miq-bot force-pushed the openapi_generate branch from d117878 to 2b81744 Compare March 4, 2025 22:12
@miq-bot
Copy link
Member Author

miq-bot commented Mar 5, 2025

Some comments on commit miq-bot@cd6063c

docs/DefaultApi.md

  • ⚠️ - 12048 - Detected puts. Remove all debugging statements.
  • ⚠️ - 12066 - Detected puts. Remove all debugging statements.
  • ⚠️ - 13838 - Detected puts. Remove all debugging statements.
  • ⚠️ - 13856 - Detected puts. Remove all debugging statements.
  • ⚠️ - 4660 - Detected puts. Remove all debugging statements.
  • ⚠️ - 4678 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member Author

miq-bot commented Mar 5, 2025

Checked commit miq-bot@cd6063c with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
688 files checked, 15 offenses detected

lib/kubevirt/models/v1_controller_revision_ref.rb

lib/kubevirt/models/v1_disk_io_threads.rb

lib/kubevirt/models/v1_instancetype_status_ref.rb

spec/models/v1_controller_revision_ref_spec.rb

spec/models/v1_disk_io_threads_spec.rb

spec/models/v1_instancetype_status_ref_spec.rb

spec/models/v1alpha1_virtual_machine_pool_name_generation_spec.rb

spec/models/v1beta1_virtual_machine_clone_list_spec.rb

spec/models/v1beta1_virtual_machine_clone_spec.rb

spec/models/v1beta1_virtual_machine_clone_spec_spec.rb

spec/models/v1beta1_virtual_machine_clone_status_spec.rb

spec/models/v1beta1_virtual_machine_clone_template_filters_spec.rb

@Fryguy
Copy link
Member

Fryguy commented Mar 5, 2025

We need to update the rubocop rules here to align with whatever openapi generates

@agrare agrare merged commit b036b83 into ManageIQ:master Mar 5, 2025
6 checks passed
@agrare
Copy link
Member

agrare commented Mar 5, 2025

The funny part is the .rubocop.yml here is also auto-generated by openapi

@Fryguy
Copy link
Member

Fryguy commented Mar 5, 2025

Sounds like we need to update the openapi generator to generate linted code haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants