[WIP] Refactor Cloud Template import image for COS sources#1223

Open

jaywcarman wants to merge 1 commit intoManageIQ:masterfrom

jaywcarman:powervs_import_image_from_cos_cloud_templates_controller_import_image

Member

jaywcarman commented May 3, 2023 •

edited

Loading

Depends on:

Add API to get list of COS objects #1221
I originally included these changes in Add API to get list of COS objects #1221 but decided each change should have separate and focused discussions.
I'll rebase these changes onto Add API to get list of COS objects #1221 before taking out of WIP and merging.

Related to:

[WIP] PowerVS import image from COS manageiq-providers-ibm_cloud#453

jaywcarman requested a review from bdunne as a code owner

May 3, 2023 17:52

jaywcarman mentioned this pull request

[WIP] PowerVS import image from COS ManageIQ/manageiq-providers-ibm_cloud#453

Closed

miq-bot added the wip label

jaywcarman mentioned this pull request

Add API to get list of COS objects #1221

Merged

miq-bot added the unmergeable label


          Add template import_resource COS source validation

686b593

Refactor the parameter validation and implicit auth checks via
'resource_search' calls to allow for both Cloud Manager templates
(existing functionality) and Storage Manager object storage objects
(newly added functionality).

After validation the 'data' still gets passed directly to the
import_image_queue class method of the destination provider.

jaywcarman force-pushed the powervs_import_image_from_cos_cloud_templates_controller_import_image branch from 56099e3 to 686b593 Compare

May 3, 2023 20:59

Member

miq-bot commented May 3, 2023

Checked commit jaywcarman@686b593 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

miq-bot removed the unmergeable label

miq-bot added the stale label

Member

miq-bot commented Aug 21, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Member

miq-bot commented Nov 27, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

7 similar comments

Member

miq-bot commented Mar 4, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Jun 10, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Sep 16, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Dec 23, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Apr 14, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Jul 21, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Member

miq-bot commented Dec 12, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels