-
Notifications
You must be signed in to change notification settings - Fork 36
Replace PowerVS System Pools API with Datacenters API #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PowerVS System Pools API with Datacenters API #536
Conversation
| X-Ibmcloud-Sdk-Analytics: | ||
| - service_name=resource_controller;service_version=V2;operation_id=get_resource_instance | ||
| Accept: | ||
| - application/json | ||
| Authorization: | ||
| - Bearer IAMBEARERTOKEN | ||
| Authorization: Bearer xxxxxx | ||
| Connection: | ||
| - close | ||
| response: | ||
| status: | ||
| code: 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this resource controller API response always has a code of 34 but the body include the requested data 😕. I manually wrote the code to 200, continued recording the rest of the specs and everything looked good. I'll push another PR that shows this issue more clearly. (done: #537)
ab496c4 to
9b3fd67
Compare
|
Checked commits jaywcarman/manageiq-providers-ibm_cloud@2f912cb~...9b3fd67 with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint lib/tasks_private/power_virtual_servers.rake
|
9b3fd67 to
8df982b
Compare
The System Pools is no longer available. The Datacenters API now providers a list of available system types (stored in MIQ as a flavor).
The default IAM uri for power_virtual_servers is 'https://iam.cloud.ibm.com/identity/token#apikey'. The resource controller URI starts with 'https://resource-controller.cloud.ibm.com' (no 'iaas' subdomain). There's no harm in sanitizing _any_ domain with cloud.ibm in it.
After creating a PVM instance, the pvm_instances_api.pcloud_pvminstances_get() for the new instance returns an HTTP 500 response for a short time. It takes a few minutes for the instance to be created anyways, so adding a 1m sleep prevents the bad response without slowing down the setup process.
Update images to newer versions that are available in the PowerVS image catalog.
The new PowerVS workspace used to record specs requires some check counts/values to be updated.
8df982b to
414d847
Compare
The PowerVS System Pools API has been deprecated and is no longer available. It was only used to get a list of available host types, which is also available in the Datacenters API.
Depends on:
ibm_cloud_powerv3.0.0 gem