[WIP] Split up "pod" images and managed container images

[agrare]

Container Images on OpenShift come from two different sources, the first is from the /apis/image.openshift.io/v1 API and the second is from pods. If a pod is using an image which isn't in the /apis/image.openshift.io/v1 we create a new "unmanaged" container image record. Currently these are of the type ::ContainerImage.

Cross-repo Tests: ManageIQ/manageiq-cross_repo-tests#632

Depends on:

• [WIP] Use auto-model-class for ContainerImages manageiq#21828
• [WIP] Subclass ContainerImage under Kubernetes manageiq-providers-kubernetes#463

[agrare]

TODO not sure why this is necessary, when the ContainerImage.disconnect_inv method is run from the context of the ManageIQ::Providers::Openshift::ContainerManager::ContainerImage class where isn't picking up on the child classes. Suspect something to do with the ActsAsStiLeafClass but need to investigate more

[agrare]

Yes this is due to ActsAsStiLeafClass using just [sti_class] for the type clause

[kbrock]

Could you update the issue description?

Currently these are of the type ::ContainerImage.

That states the before, could you share what the after value will be?

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

Checked commits agrare/manageiq-providers-openshift@5b83538~...94ed605 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
7 files checked, 3 offenses detected

app/models/manageiq/providers/openshift/container_manager/container_image.rb

• ❗ - Line 7, Col 5 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 8, Col 34 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

app/models/manageiq/providers/openshift/container_manager/managed_container_image.rb

• ❗ - Line 40, Col 7 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.