[WIP] Handle nil storage domain store type#698
Open
agrare wants to merge 1 commit intoManageIQ:masterfrom
Open
[WIP] Handle nil storage domain store type#698agrare wants to merge 1 commit intoManageIQ:masterfrom
nil storage domain store type#698agrare wants to merge 1 commit intoManageIQ:masterfrom
Conversation
Handle the case where `storagedomain` store type is `nil` which would fall into the using the volume_group id for the location.
Member
|
Checked commit agrare@4dac59c with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case where
storagedomainstore type isnilwhich would fall into the using the volume_group id for the location.We do use
Storage#store_typefor other things (namely smartstate analysis) so I don't think we should just leave it blank but this fixes the exception blocking refresh.Fixes #697