Merge pull request #809 from kbrock/host_states

Move vmware Host power_state logic to vmware

Author: agrare

app/models/manageiq/providers/vmware/infra_manager/host.rb

@@ -2,10 +2,29 @@ class ManageIQ::Providers::Vmware::InfraManager::Host < ::Host
   include ManageIQ::Providers::Vmware::InfraManager::VimConnectMixin
   include ManageIQ::Providers::Vmware::InfraManager::EmsRefObjMixin
 
+  # overrides base start to support "standby" powerstate
+  supports :start do
+    if !supports?(:ipmi)
+      unsupported_reason_add(:start, unsupported_reason(:ipmi))
+    elsif %w[off standby].exclude?(power_state)
+      unsupported_reason_add(:start, _("The Host is not in power state off or standby"))
+    end
+  end
+
   def connect(options = {})
     vim_connect(options)
   end
 
+  def start
+    if verbose_supports?(:start)
+      if power_state == 'standby'
+        check_policy_prevent("request_host_start", "vim_power_up_from_standby")
+      else
+        super
+      end
+    end
+  end
+
   def provider_object(connection)
     api_type = connection.about["apiType"]
     mor =

spec/models/manageiq/providers/vmware/infra_manager/host_spec.rb

@@ -1,90 +1,124 @@
 describe ManageIQ::Providers::Vmware::InfraManager::Host do
-  before(:each) do
-    @host = FactoryBot.create(:host_vmware)
+  include Spec::Support::SupportsHelper
+
+  let(:ems)  { FactoryBot.create(:ems_vmware) }
+  let(:host) { FactoryBot.create(:host_vmware, :ext_management_system => ems) }
+
+  describe "supports :start" do
+    let(:host) { FactoryBot.create(:host_vmware, :ext_management_system => ems, :power_state => power_state) }
+
+    before { EvmSpecHelper.local_miq_server }
+
+    context "when it does not support ipmi" do
+      before do
+        stub_supports_all_others(Host)
+        stub_supports_not(Host, :ipmi)
+      end
+
+      let(:power_state) { "off" }
+      it { expect(host.supports?(:start)).to be_falsey }
+    end
+
+    context "when it supports ipmi" do
+      before do
+        stub_supports_all_others(Host)
+        stub_supports(Host, :ipmi)
+      end
+
+      context "when off" do
+        let(:power_state) { "off" }
+        it { expect(host.supports?(:start)).to be_truthy }
+      end
+
+      context "when on" do
+        let(:power_state) { "on" }
+        it { expect(host.supports?(:start)).to be_falsey }
+      end
+
+      # new in this provider
+      context "when standby" do
+        let(:power_state) { "standby" }
+        it { expect(host.supports?(:start)).to be_truthy }
+      end
+    end
   end
 
   context "#reserve_next_available_vnc_port" do
     context "without EMS defaults set" do
-      before(:each) do
-        @ems = FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => nil, :host_default_vnc_port_end => nil)
-        @host.ext_management_system = @ems
-      end
+      let(:ems)  { FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => nil, :host_default_vnc_port_end => nil) }
 
       it "normal case" do
-        @host.update(:next_available_vnc_port => 5901)
+        host.update(:next_available_vnc_port => 5901)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5901)
-        expect(@host.next_available_vnc_port).to eq(5902)
+        expect(host.reserve_next_available_vnc_port).to eq(5901)
+        expect(host.next_available_vnc_port).to eq(5902)
       end
 
       it "with last value of nil" do
-        @host.update(:next_available_vnc_port => nil)
+        host.update(:next_available_vnc_port => nil)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
 
       it "with last value at end of range" do
-        @host.update(:next_available_vnc_port => 5999)
+        host.update(:next_available_vnc_port => 5999)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5999)
-        expect(@host.next_available_vnc_port).to eq(5900)
+        expect(host.reserve_next_available_vnc_port).to eq(5999)
+        expect(host.next_available_vnc_port).to eq(5900)
       end
 
       it "with last value before start of range" do
-        @host.update(:next_available_vnc_port => 5899)
+        host.update(:next_available_vnc_port => 5899)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
 
       it "with last value after end of range" do
-        @host.update(:next_available_vnc_port => 6000)
+        host.update(:next_available_vnc_port => 6000)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5900)
-        expect(@host.next_available_vnc_port).to eq(5901)
+        expect(host.reserve_next_available_vnc_port).to eq(5900)
+        expect(host.next_available_vnc_port).to eq(5901)
       end
     end
 
     context "with EMS defaults set" do
-      before(:each) do
-        @ems = FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => 5925, :host_default_vnc_port_end => 5930)
-        @host.ext_management_system = @ems
-      end
+      let(:ems)  { FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => 5925, :host_default_vnc_port_end => 5930) }
 
       it "normal case" do
-        @host.update(:next_available_vnc_port => 5926)
+        host.update(:next_available_vnc_port => 5926)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5926)
-        expect(@host.next_available_vnc_port).to eq(5927)
+        expect(host.reserve_next_available_vnc_port).to eq(5926)
+        expect(host.next_available_vnc_port).to eq(5927)
       end
 
       it "with last value of nil" do
-        @host.update(:next_available_vnc_port => nil)
+        host.update(:next_available_vnc_port => nil)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
 
       it "with last value at end of range" do
-        @host.update(:next_available_vnc_port => 5930)
+        host.update(:next_available_vnc_port => 5930)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5930)
-        expect(@host.next_available_vnc_port).to eq(5925)
+        expect(host.reserve_next_available_vnc_port).to eq(5930)
+        expect(host.next_available_vnc_port).to eq(5925)
       end
 
       it "with last value before start of range" do
-        @host.update(:next_available_vnc_port => 5924)
+        host.update(:next_available_vnc_port => 5924)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
 
       it "with last value after end of range" do
-        @host.update(:next_available_vnc_port => 5931)
+        host.update(:next_available_vnc_port => 5931)
 
-        expect(@host.reserve_next_available_vnc_port).to eq(5925)
-        expect(@host.next_available_vnc_port).to eq(5926)
+        expect(host.reserve_next_available_vnc_port).to eq(5925)
+        expect(host.next_available_vnc_port).to eq(5926)
       end
     end
   end