move supports standby from core to vmware

Author: kbrock

app/models/manageiq/providers/vmware/infra_manager/host.rb

@@ -2,10 +2,29 @@ class ManageIQ::Providers::Vmware::InfraManager::Host < ::Host
   include ManageIQ::Providers::Vmware::InfraManager::VimConnectMixin
   include ManageIQ::Providers::Vmware::InfraManager::EmsRefObjMixin
 
+  # overrides base start to support "standby" powerstate
+  supports :start do
+    if !supports?(:ipmi)
+      unsupported_reason_add(:start, unsupported_reason(:ipmi))
+    elsif %w[off standby].exclude?(power_state)
+      unsupported_reason_add(:start, _("The Host is not in power state off or standby"))
+    end
+  end
+
   def connect(options = {})
     vim_connect(options)
   end
 
+  def start
+    if verbose_supports?(:start)
+      if power_state == 'standby'
+        check_policy_prevent("request_host_start", "vim_power_up_from_standby")
+      else
+        super
+      end
+    end
+  end
+
   def provider_object(connection)
     api_type = connection.about["apiType"]
     mor =

spec/models/manageiq/providers/vmware/infra_manager/host_spec.rb

@@ -1,7 +1,48 @@
 describe ManageIQ::Providers::Vmware::InfraManager::Host do
+  include Spec::Support::SupportsHelper
+
   let(:ems)  { FactoryBot.create(:ems_vmware) }
   let(:host) { FactoryBot.create(:host_vmware, :ext_management_system => ems) }
 
+  describe "supports :start" do
+    let(:host) { FactoryBot.create(:host_vmware, :ext_management_system => ems, :power_state => power_state) }
+
+    before { EvmSpecHelper.local_miq_server }
+
+    context "when it does not support ipmi" do
+      before do
+        stub_supports_all_others(Host)
+        stub_supports_not(Host, :ipmi)
+      end
+
+      let(:power_state) { "off" }
+      it { expect(host.supports?(:start)).to be_falsey }
+    end
+
+    context "when it supports ipmi" do
+      before do
+        stub_supports_all_others(Host)
+        stub_supports(Host, :ipmi)
+      end
+
+      context "when off" do
+        let(:power_state) { "off" }
+        it { expect(host.supports?(:start)).to be_truthy }
+      end
+
+      context "when on" do
+        let(:power_state) { "on" }
+        it { expect(host.supports?(:start)).to be_falsey }
+      end
+
+      # new in this provider
+      context "when standby" do
+        let(:power_state) { "standby" }
+        it { expect(host.supports?(:start)).to be_truthy }
+      end
+    end
+  end
+
   context "#reserve_next_available_vnc_port" do
     context "without EMS defaults set" do
       let(:ems)  { FactoryBot.create(:ems_vmware, :host_default_vnc_port_start => nil, :host_default_vnc_port_end => nil) }