Removing Memoization

Author: MelsHyrule

app/models/manageiq/providers/vmware/cloud_manager.rb

@@ -35,7 +35,7 @@ def self.description
   end
 
   def self.params_for_create
-    @params_for_create ||= {
+    {
       :fields => [
         {
           :component    => "select",
@@ -208,15 +208,15 @@ def self.params_for_create
                         :component  => "text-field",
                         :id         => "authentications.amqp.userid",
                         :name       => "authentications.amqp.userid",
-                        :label      => "Username",
+                        :label      => _("Username"),
                         :isRequired => true,
                         :validate   => [{:type => "required"}],
                       },
                       {
                         :component  => "password-field",
                         :id         => "authentications.amqp.password",
                         :name       => "authentications.amqp.password",
-                        :label      => "Password",
+                        :label      => _("Password"),
                         :type       => "password",
                         :isRequired => true,
                         :validate   => [{:type => "required"}],

app/models/manageiq/providers/vmware/container_manager.rb

@@ -82,7 +82,7 @@ def self.verify_credentials(args)
   end
 
   def self.params_for_create
-    @params_for_create ||= {
+    {
       :fields => [
         {
           :component => 'sub-form',

app/models/manageiq/providers/vmware/infra_manager.rb

@@ -53,7 +53,7 @@ def self.description
     end
 
     def self.params_for_create
-      @params_for_create ||= {
+      {
         :fields => [
           {
             :component => 'text-field',
@@ -216,15 +216,15 @@ def self.params_for_create
                           :component  => "text-field",
                           :id         => "authentications.console.userid",
                           :name       => "authentications.console.userid",
-                          :label      => "Username",
+                          :label      => _("Username"),
                           :isRequired => true,
                           :validate   => [{:type => "required"}],
                         },
                         {
                           :component  => "password-field",
                           :id         => "authentications.console.password",
                           :name       => "authentications.console.password",
-                          :label      => "Password",
+                          :label      => _("Password"),
                           :type       => "password",
                           :isRequired => true,
                           :validate   => [{:type => "required"}],