Move updating the RPM repo to an independent task for reusability#620
Open
bdunne wants to merge 2 commits intoManageIQ:masterfrom
Open
Move updating the RPM repo to an independent task for reusability#620bdunne wants to merge 2 commits intoManageIQ:masterfrom
bdunne wants to merge 2 commits intoManageIQ:masterfrom
Conversation
Member
|
For this to be reusable it needs to have workflow_call. Also is this repo the best location or would it make more sense at the org level (i.e. ManageIQ/.github)? |
e12689e to
ebf04f4
Compare
Member
|
Checked commits bdunne/manageiq-rpm_build@ebf04f4~...5e06327 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint **
|
Fryguy
reviewed
Feb 23, 2026
| cmd="bin/build_hotfix.rb $@" | ||
| elif [[ $1 == "update_rpm_repo" ]]; then | ||
| shift | ||
| cmd="bin/update_rpm_repo.rb $@" |
Member
There was a problem hiding this comment.
The script is called run_update_rpm_repo, right? (Not sure I understand 2 scripts with similar names if they are different?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.