Fix button form save button validation #9501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GilbertCherrie I manually tested against #9470 and both issues are resolved. Now to review the code. |
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
jrafanie
reviewed
Jun 19, 2025
| end | ||
| else # if new value and current value are not equal | ||
| @changed = session[:changed] = true | ||
| break |
There was a problem hiding this comment.
We might want to extract methods out of these conditional where you can give a decent name to the logic... it's going to be hard to test this in a unit test without smaller methods.
|
The behavior changes look good but I think we need some unit tests for some of the complex logic you managed to figure out. |
GilbertCherrie
force-pushed
the
fix_button_form_change_field_validation
branch
from
45630b9 to
c441f4f
Compare
jrafanie
reviewed
Jun 23, 2025
|
Checked commits GilbertCherrie/manageiq-ui-classic@c441f4f~...e506a50 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint app/controllers/application_controller/buttons.rb
|
GilbertCherrie
force-pushed
the
fix_button_form_change_field_validation
branch
4 times, most recently
from
d1470ab to
7d36eeb
Compare
GilbertCherrie
force-pushed
the
fix_button_form_change_field_validation
branch
from
7d36eeb to
d0ce60d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9470
This pr fixes an issue where changing the attributes or roles doesn't properly enable/disable the save button on the button form