[WIP] Extract the tenant id from the x_node #9527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using params for the action rbac_tenant_delete is correct for this action. It should not be used for any role_allows? calls as they can be for doing different actions/product features. For example, after deleting a tenant, the subsequent call to replace the right cell and update the screen after the deletion should not refer to an already deleted tenant. Fixes ManageIQ#9512
|
cool, tests failed... looking |
Fryguy
reviewed
Jul 24, 2025
| end | ||
|
|
||
| if MiqProductFeature.my_root_tenant_identifier?(options[:feature]) && self.x_node.to_s.start_with?("tn-") | ||
| _, id, _ = TreeBuilder.extract_node_model_and_id(self.x_node.to_s) |
There was a problem hiding this comment.
Bonus whitespace
Suggested change
| _, id, _ = TreeBuilder.extract_node_model_and_id(self.x_node.to_s) | |
| _, id, _ = TreeBuilder.extract_node_model_and_id(self.x_node.to_s) |
will need to look at this later... it looks like basic button role_allows_feature? expects to be able to pull out the controller's params id to check if the role_allows the button action. Note, we don't actually pass the tenant id to the button, it pulls it from the controller's params. 😭 What a mess: I have concern other areas may also rely on checking the controller's params. 🤷 |
jrafanie
changed the title
|
Ugh, ok. We may have to detangle this one together and/or find a way to drop that role_allows? override. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using params for the action rbac_tenant_delete is correct for this action.
It should not be used for any role_allows? calls as they can be for doing different actions/product features. For example, after deleting a tenant, the subsequent call to replace the right cell and update the screen after the deletion should not refer to an already deleted tenant.
Fixes #9512. Replaces #9523