Use the count directly to avoid 2 notifications calls per page #9536
Conversation
Depends on ManageIQ/manageiq-api#1293, which ensures that `count` actually is the full count we are looking for. Fixes ManageIQ#9448
| .then((data) => { | ||
| const notifications = data.resources.map(convert); | ||
|
|
||
| return { | ||
| notifications, | ||
| subcount: data.subcount, | ||
| subcount: data.count |
There was a problem hiding this comment.
I was going to rename this key to count also, but that feels like a much more invasive change, so I left it for now.
|
@asirvadAbrahamVarghese Can you look at the failures on this one? I think we were expecting the notifications calls in the failing tests and now they're gone due to the changes in this PR. Can you try this PR locally and see if it's the explicit wait on the notifications that's the problem: |
|
Oh I can remove them. I didn't realize we had waits on notifications |
Is this a blocker for an urgent release? PR #9516 will remove it |
|
Bumping CI after #9516 merge |
There was a problem hiding this comment.
Nice, 💚 tests. Thanks @asirvadAbrahamVarghese. LGTM @Fryguy.
Depends on ManageIQ/manageiq-api#1293, which ensures that
countactually is the full count we are looking for.Fixes #9448
@kbrock Please review.