Skip to content

Update jest, cypress packages to resolve security issues caused by form-data #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged

Update jest, cypress packages to resolve security issues caused by form-data #9539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4093bb
Update form-data to use version 4.0.4
elsamaryv Aug 6, 2025
b963281
jest and jest-cli updated
elsamaryv Aug 12, 2025
66cb6bc
updated cypress to 14.5.0
elsamaryv Aug 12, 2025
f18bef0
Reverts jest-cli pkg update
elsamaryv Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@
"nwsapi": "^2.2.1",
"path-to-regexp": "~8.0.0",
"patternfly": "~3.59.5",
"terser": "~4.8.1"
"terser": "~4.8.1",
"form-data": "~4.0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elsamaryv one small fix, can you please put this in alphabetical order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe form-data 2.5.5 also contains the fix. Can we upgrade to that version instead to prevent such a big version jump from 2.3.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do this without using resolutions? (IMO resolutions only should be used as a last resort). If we can update jest/jest-cli, perhaps newer versions support the right version range

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @elsamaryv can you first try to upgrade the jest and jest-cli packages then see if it upgrades the form data package. If you are able to upgrade jest and jest-cli see what the most recent version you can get to for those without anything breaking and then see if that causes form-data to upgrade also.

Copy link
Contributor Author

@elsamaryv elsamaryv Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Jest and Cypress packages that previously included form-data via transitive dependencies. With these updates, form-data resolves to the patched versions 3.0.4 and 4.0.4. However, upgrading jest-cli causes multiple test/suite failures, so I had to retain the current version, which still depends on the vulnerable [email protected].

Running yarn why form-data shows:

Screenshot 2025-08-12 at 6 46 54 PM Screenshot 2025-08-12 at 6 47 21 PM

}
}
21 changes: 5 additions & 16 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5123,7 +5123,7 @@ __metadata:
languageName: node
linkType: hard

"combined-stream@npm:^1.0.6, combined-stream@npm:^1.0.8, combined-stream@npm:~1.0.6":
"combined-stream@npm:^1.0.8, combined-stream@npm:~1.0.6":
version: 1.0.8
resolution: "combined-stream@npm:1.0.8"
dependencies:
Expand Down Expand Up @@ -8301,27 +8301,16 @@ __metadata:
languageName: node
linkType: hard

"form-data@npm:~2.3.2":
version: 2.3.3
resolution: "form-data@npm:2.3.3"
dependencies:
asynckit: "npm:^0.4.0"
combined-stream: "npm:^1.0.6"
mime-types: "npm:^2.1.12"
checksum: 10/1b6f3ccbf4540e535887b42218a2431a3f6cfdea320119c2affa2a7a374ad8fdd1e60166fc865181f45d49b1684c3e90e7b2190d3fe016692957afb9cf0d0d02
languageName: node
linkType: hard

"form-data@npm:~4.0.0":
version: 4.0.3
resolution: "form-data@npm:4.0.3"
"form-data@npm:~4.0.4":
version: 4.0.4
resolution: "form-data@npm:4.0.4"
dependencies:
asynckit: "npm:^0.4.0"
combined-stream: "npm:^1.0.8"
es-set-tostringtag: "npm:^2.1.0"
hasown: "npm:^2.0.2"
mime-types: "npm:^2.1.12"
checksum: 10/22f6e55e6f32a5797a500ed7ca5aa9d690c4de6e1b3308f25f0d83a27d08d91a265ab59a190db2305b15144f8f07df08e8117bad6a93fc93de1baa838bfcc0b5
checksum: 10/a4b62e21932f48702bc468cc26fb276d186e6b07b557e3dd7cc455872bdbb82db7db066844a64ad3cf40eaf3a753c830538183570462d3649fdfd705601cbcfb
languageName: node
linkType: hard

Expand Down
Loading