Skip to content

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Aug 11, 2025

Removed the code mirror technical debt. This will clean up our code base for later when we need to convert the fewer code mirrors left in the code.

Also:

  • miq_none: any code mirror with this is no longer being used and canbe removed.
  • template_script_data.html.haml: this file can be deleted because the code mirror is rendered in this file _template_details.html.haml.
  • app/views/miq_ae_class/show.html.haml: this file can be deleted because it is not used to render the class summary screen

@GilbertCherrie GilbertCherrie force-pushed the remove_codemirror_tech_debt branch from 65a3144 to 20cd127 Compare August 11, 2025 16:11
@Fryguy
Copy link
Member

Fryguy commented Aug 11, 2025

@elsamaryv Please review

@jrafanie
Copy link
Member

Close / open after revert of #9505 via #9553

@jrafanie jrafanie closed this Aug 13, 2025
@jrafanie jrafanie reopened this Aug 13, 2025
@Fryguy Fryguy merged commit b2d28aa into ManageIQ:master Aug 18, 2025
36 of 38 checks passed
@GilbertCherrie GilbertCherrie deleted the remove_codemirror_tech_debt branch August 18, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants