Skip to content

Conversation

GilbertCherrie
Copy link
Member

Fix builtin method summary screen.

Before:
Screenshot 2025-08-11 at 12 05 10 PM

After:
Screenshot 2025-08-11 at 12 06 53 PM

Also, the previous function method_built_in_data was named incorrectly. It is intended to represent inline_data and display the code mirror. This has been changed to method_inline_data and the uses of it have been replaced with the new name instead.

@jrafanie
Copy link
Member

Close / open after revert of #9505 via #9553

@jrafanie jrafanie closed this Aug 13, 2025
@jrafanie jrafanie reopened this Aug 13, 2025
@GilbertCherrie
Copy link
Member Author

@elsamaryv please review

@Fryguy Fryguy assigned elsamaryv and unassigned Fryguy Aug 18, 2025
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GilbertCherrie Do we have a cypress test that should have failed previously? Can it be added using the normal seeded database information?

@GilbertCherrie
Copy link
Member Author

@jrafanie No we don't have any cypress tests for this page. It can be added but should we just do that in a future pr since this is just a simple UI display fix

@jrafanie
Copy link
Member

@GilbertCherrie so, I tried to see what we have in the seeded database and I don't really understand what it's supposed to show. These all look the same. What do we need to show something with data?

image image image

@GilbertCherrie
Copy link
Member Author

@jrafanie they would need to have a built in name value set in the form. I believe its an optional field thats why the values are all blank there.

@GilbertCherrie
Copy link
Member Author

GilbertCherrie commented Aug 19, 2025

@jrafanie All this pr does is make the bottom of this page look nicer:

image

Do you notice how it just says test on the bottom of the page. This value is the built in name of this method. This pr just puts it in a table. It is purely a display fix.

image

@jrafanie
Copy link
Member

LGTM, we can do a test later if we have the data from a seeded db.

@jrafanie jrafanie merged commit 5b9ab17 into ManageIQ:master Aug 19, 2025
36 of 38 checks passed
@jrafanie jrafanie assigned jrafanie and unassigned elsamaryv Aug 19, 2025
@jrafanie
Copy link
Member

@GilbertCherrie can you add spassky? I assume it's good to go back.

@GilbertCherrie GilbertCherrie deleted the fix_inline_method_summary_screen branch August 20, 2025 12:52
@Fryguy
Copy link
Member

Fryguy commented Aug 21, 2025

Backported to spassky in commit a15203b.

commit a15203bfe61dc10f7d191f1e5b251f7ac537201e
Author: Joe Rafaniello <[email protected]>
Date:   Tue Aug 19 19:31:22 2025 -0400

    Merge pull request #9551 from GilbertCherrie/fix_inline_method_summary_screen
    
    Fix builtin method summary screen
    
    (cherry picked from commit 5b9ab172d97fc9aefd16cbc50e1cf84401b6120d)

Fryguy pushed a commit that referenced this pull request Aug 21, 2025
…y_screen

Fix builtin method summary screen

(cherry picked from commit 5b9ab17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants