-
Notifications
You must be signed in to change notification settings - Fork 365
Fix builtin method summary screen #9551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builtin method summary screen #9551
Conversation
@elsamaryv please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GilbertCherrie Do we have a cypress test that should have failed previously? Can it be added using the normal seeded database information?
@jrafanie No we don't have any cypress tests for this page. It can be added but should we just do that in a future pr since this is just a simple UI display fix |
@GilbertCherrie so, I tried to see what we have in the seeded database and I don't really understand what it's supposed to show. These all look the same. What do we need to show something with data? ![]() ![]() ![]() |
@jrafanie they would need to have a built in name value set in the form. I believe its an optional field thats why the values are all blank there. |
@jrafanie All this pr does is make the bottom of this page look nicer: ![]() Do you notice how it just says test on the bottom of the page. This value is the built in name of this method. This pr just puts it in a table. It is purely a display fix. ![]() |
LGTM, we can do a test later if we have the data from a seeded db. |
@GilbertCherrie can you add spassky? I assume it's good to go back. |
Backported to
|
…y_screen Fix builtin method summary screen (cherry picked from commit 5b9ab17)
Fix builtin method summary screen.
Before:

After:

Also, the previous function
method_built_in_data
was named incorrectly. It is intended to represent inline_data and display the code mirror. This has been changed tomethod_inline_data
and the uses of it have been replaced with the new name instead.