Enhance expect alerts command #9557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, as we are planning to use


flashClassMap
to mention flash type inexpect_flash
command, passingflashClassMap.error
(which equals 'danger') would fail because the command looked for a key named 'danger'(for danger the key name is 'error') in the mapand defaulted to 'success' when not found.
Similarly any other invalid values passed will also default to 'success' due to this condition ⬇️
Before:
Fails after looking for alert-success when an invalid flash-type is passed to the command

After:
Fails with a proper error message:

@miq-bot assign @GilbertCherrie
@miq-bot add-label cypress
@miq-bot add-label test