Skip to content

Conversation

asirvadAbrahamVarghese
Copy link
Contributor

From now on, as we are planning to use flashClassMap to mention flash type in expect_flash command, passing flashClassMap.error (which equals 'danger') would fail because the command looked for a key named 'danger'(for danger the key name is 'error') in the map
image
and defaulted to 'success' when not found.
Similarly any other invalid values passed will also default to 'success' due to this condition ⬇️
image

Before:

Fails after looking for alert-success when an invalid flash-type is passed to the command
image

After:

Fails with a proper error message:
image

@miq-bot assign @GilbertCherrie
@miq-bot add-label cypress
@miq-bot add-label test

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit 30db374 into ManageIQ:master Aug 18, 2025
18 checks passed
@jrafanie jrafanie assigned jrafanie and unassigned GilbertCherrie Aug 18, 2025
@jrafanie
Copy link
Member

@Fryguy thoughts on spassky/yes
#9539 updates cypress/jest for form-data
#9554 adds flashClassMap
#9557 depends on flashClassMap

@jrafanie
Copy link
Member

he said, yup, add the labels 😉

@Fryguy
Copy link
Member

Fryguy commented Aug 19, 2025

Backported to spassky in commit 1f1e603.

commit 1f1e603d515b973b067c606f461a89ff634ce82f
Author: Joe Rafaniello <[email protected]>
Date:   Mon Aug 18 16:25:31 2025 -0400

    Merge pull request #9557 from asirvadAbrahamVarghese/enhance-expect-alerts-command
    
    Enhance expect alerts command
    
    (cherry picked from commit 30db3745b5acec371b3ff0cf490e8a0d5dd0b086)

Fryguy pushed a commit that referenced this pull request Aug 19, 2025
…lerts-command

Enhance expect alerts command

(cherry picked from commit 30db374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants