Skip to content

Split textConstants object into individual variables #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Split textConstants object into individual variables #9575

merged 1 commit into from
Aug 22, 2025

Conversation

@asirvadAbrahamVarghese
Copy link
Contributor

@asirvadAbrahamVarghese asirvadAbrahamVarghese commented Aug 22, 2025

This PR is to remove textConstants map and to use individual constants as discussed in #9563

@miq-bot assign @jrafanie
@miq-bot add-label refactoring
@miq-bot add-label cypress
@miq-bot add-label test

@asirvadAbrahamVarghese asirvadAbrahamVarghese requested a review from a team as a code owner August 22, 2025 13:09
@asirvadAbrahamVarghese asirvadAbrahamVarghese mentioned this pull request Aug 22, 2025
Closed
jrafanie
jrafanie approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit 9509dbd into ManageIQ:master Aug 22, 2025
18 checks passed
@Fryguy
Copy link
Member

Fryguy commented Aug 27, 2025

Backported to spassky in commit 37e4992.

commit 37e4992afe1ed95774ab84e98c5fbc2dfc0bce8a
Author: Joe Rafaniello <[email protected]>
Date:   Fri Aug 22 10:39:51 2025 -0400

    Merge pull request #9575 from asirvadAbrahamVarghese/edit-collect-logs-form-cypress-refactor
    
    Split textConstants object into individual variables
    
    (cherry picked from commit 9509dbd33beb504655635b240b8014cf58c01651)

Fryguy pushed a commit that referenced this pull request Aug 27, 2025
@jrafanie @Fryguy
Merge pull request #9575 from asirvadAbrahamVarghese/edit-collect-log…
37e4992 
…s-form-cypress-refactor

Split textConstants object into individual variables

(cherry picked from commit 9509dbd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels

cypress refactoring spassky/backported test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asirvadAbrahamVarghese @Fryguy @jrafanie @miq-bot