Enhance form element selectors #9701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
reviewed
Nov 3, 2025
| ##### element_selectors | ||
|
|
||
| * `cy.getFormFooterButtonByTypeWithText({ buttonType, buttonText, buttonWrapperClass })` - retrieves form footer button by its name and type. `buttonText` is the name or text content of the button. `buttonType` is the HTML button type (e.g., 'button', 'submit', 'reset'). Defaults to 'button'. `buttonWrapperClass` is the CSS class of the wrapper element containing the buttons. Defaults to 'bx--btn-set'. e.g. `cy.getFormFooterButtonByTypeWithText({buttonText: 'Cancel'});`, `cy.getFormFooterButtonByTypeWithText({buttonText: 'Submit', buttonType: 'submit'});`, `cy.getFormFooterButtonByTypeWithText({buttonText: 'Save', buttonWrapperClass: 'custom-wrapper'});` | ||
| * `cy.getFormButtonByTypeWithText({ buttonType, buttonText })` - retrieves form footer button by its name and type. `buttonText` is the name or text content of the button. `buttonType` is the HTML button type (e.g., 'button', 'submit', 'reset'). Defaults to 'button'. e.g. `cy.getFormButtonByTypeWithText({buttonText: 'Cancel'});`, `cy.getFormButtonByTypeWithText({buttonText: 'Submit', buttonType: 'submit'});` |
Member
There was a problem hiding this comment.
according to #9689 we wanted to generalize this to be form buttons not just in footers... maybe:
retrieves a form button, often found in form footers, by its name and type
Member
There was a problem hiding this comment.
If it makes sense, let's fix this in a followup.
jrafanie
approved these changes
Nov 3, 2025
Member
jrafanie
left a comment
jrafanie
left a comment
There was a problem hiding this comment.
LGTM, minor comment can be addressed in a followup
asirvadAbrahamVarghese
added a commit
to asirvadAbrahamVarghese/manageiq-ui-classic
that referenced
this pull request
Nov 5, 2025
asirvadAbrahamVarghese
added a commit
to asirvadAbrahamVarghese/manageiq-ui-classic
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work as discussed in #9689
Renaming:
getFormFooterButtonByTypeWithText->getFormButtonByTypeWithTextvalidateFormFooterButtons->validateFormButtons@miq-bot add-label cypress
@miq-bot add-label refactoring
@miq-bot assign @jrafanie