[WIP] Fix custom buttons using role names that can change #9709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
commented
Nov 4, 2025
| edit[:new][:roles] = [old_role.id, role.id.to_s] # old roles are represented by int and new ones by string | ||
| controller.send(:button_set_record_vars, custom_button) | ||
| expect(custom_button.visibility[:roles]).to eq([old_role.name, role.name]) | ||
| expect(custom_button.visibility[:roles]).to eq([old_role.id, role.id.to_s]) |
Member
Author
There was a problem hiding this comment.
TODO: that comment on line 347 is nuts. I need to figure out if roles as strings and ints is an actual thing.
jrafanie
commented
Nov 4, 2025
| roles.push(role.name) if role | ||
| end | ||
| button.visibility[:roles] = roles | ||
| button.visibility[:roles] = @edit[:new][:roles] |
Member
Author
There was a problem hiding this comment.
TODO: keep the lookup but drop the loop...
button.visibility[:roles] = MiqUserRole.where(:id => @edit[:new][:roles]).pluck(:id)
jrafanie
added a commit
to jrafanie/manageiq-ui-classic
that referenced
this pull request
Nov 4, 2025
Based on changes in ManageIQ#9709
jrafanie
force-pushed
the
fix-custom-buttons-using-role-names-that-can-change
branch
from
03d702e to
725a24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Extract the Widget change for a followup that is based on the changes here.
Store these things in a different key such as
:role_idsMake sure any shared code in widgets / custom buttons are not broken by this change.
Research the comment regarding both string and int role ids in the
@editnew/old arrays, one for old and new values.[ ] Write a data migration to convert existing CustomButton rows with visibility columns from:
To:
Or(see the first bullet):