Fix the react forms for catalog items#9904
Open
GilbertCherrie wants to merge 2 commits intoManageIQ:masterfrom
Open
Fix the react forms for catalog items#9904GilbertCherrie wants to merge 2 commits intoManageIQ:masterfrom
GilbertCherrie wants to merge 2 commits intoManageIQ:masterfrom
Conversation
Fryguy
reviewed
Mar 12, 2026
Comment on lines
+2
to
+3
| - if @checked_id.nil? | ||
| - @checked_id = 'new' |
Member
There was a problem hiding this comment.
Can this be done in the controller?
Member
Author
There was a problem hiding this comment.
@Fryguy I moved this to the controller file. I tested the add/edit/copy form with all possible entry points into this form and it seems to be working now
Member
|
Checked commits GilbertCherrie/manageiq-ui-classic@c14477b~...732ccef with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint app/controllers/catalog_controller.rb
app/views/catalog/_st_angular_form.html.haml
app/views/catalog/_tt_react_form.html.haml |
Fryguy
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the React catalog item forms (Ansible playbook and Terraform) were breaking due to not receiving the correct ID value. This was broken due to this pr: #9865.
Before:
When you select an Ansible playbook or Terraform template item from the catalog table checkbox and select Configuration / Edit Item, it hits an error.
After:
