[C] Use rspec-rebound to avoid sequence errors with ingestion test

Author: scryptmouse

api/Gemfile

@@ -147,7 +147,7 @@ group :development, :test do
   gem "rspec-json_expectations", "~> 2.0"
   gem "rspec-mocks", "~> 3.0"
   gem "rspec-rails", "> 6"
-  gem "rspec-retry", "~> 0.6.2"
+  gem "rspec-rebound", "~> 0.2.1"
   gem "rspec-support", "~> 3.0"
   gem "rswag", "~> 2.16"
   gem "rswag-api", "2.16.0"

api/Gemfile.lock

@@ -667,8 +667,8 @@ GEM
       rspec-expectations (~> 3.12)
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
-    rspec-retry (0.6.2)
-      rspec-core (> 3.3)
+    rspec-rebound (0.2.1)
+      rspec-core (~> 3.3)
     rspec-support (3.12.1)
     rswag (2.16.0)
       rswag-api (= 2.16.0)
@@ -975,7 +975,7 @@ DEPENDENCIES
   rspec-json_expectations (~> 2.0)
   rspec-mocks (~> 3.0)
   rspec-rails (> 6)
-  rspec-retry (~> 0.6.2)
+  rspec-rebound (~> 0.2.1)
   rspec-support (~> 3.0)
   rswag (~> 2.16)
   rswag-api (= 2.16.0)

api/spec/services/ingestions/post_processors/set_start_section_spec.rb

@@ -5,24 +5,32 @@
 RSpec.describe Ingestions::PostProcessors::SetStartSection do
   include TestHelpers::IngestionHelper
 
+  let_it_be(:project, refind: true) { FactoryBot.create :project }
+  let_it_be(:creator, refind: true) { FactoryBot.create :user }
+
   shared_examples_for "the start section assignment" do |section_name|
-    before { described_class.run(manifest: manifest, text: text, context: context) }
+    it "determines the start_text_section_id", retry: 5 do
+      expect do
+        described_class.run!(manifest:, text:, context:)
+      end.to execute_safely
 
-    it "determines the start_text_section_id" do
       expect(text.start_text_section).not_to be_nil
       expect(text.start_text_section.name).to eq section_name
     end
   end
 
   context "when manifest" do
-    let!(:ingestion) { FactoryBot.create :ingestion, :uningested, :file_source, source_path: path }
+    let!(:ingestion) { FactoryBot.create :ingestion, :uningested, :file_source, project:, creator:, source_path: path }
+
     let(:context) { create_context(ingestion) }
+
     let(:manifest) do
-      manifest = Ingestions::Strategies::Manifest.run(context: context).result
-      manifest = Ingestions::PreProcessor.run(context: context, manifest: manifest).result
-      manifest
+      Ingestions::Strategies::Manifest.run!(context:).then do |manifest|
+        Ingestions::PreProcessor.run!(context:, manifest:)
+      end
     end
-    let!(:text) { Ingestions::Compiler.run(manifest: manifest, context: context).result }
+
+    let!(:text) { Ingestions::Compiler.run!(manifest:, context:) }
 
     context "when starting section source is referenced multiple times" do
       let(:path) { Rails.root.join("spec", "data", "ingestion", "manifest", "all_local.zip") }
@@ -38,13 +46,16 @@
   end
 
   context "when epub" do
-    let!(:ingestion) { FactoryBot.create :ingestion, :uningested, :file_source, source_path: path }
+    let!(:ingestion) { FactoryBot.create :ingestion, :uningested, :file_source, project:, creator:, source_path: path }
+
     let(:context) { create_context(ingestion) }
+
     let(:manifest) do
-      manifest = Ingestions::Strategies::Epub.run(context: context).result
-      manifest = Ingestions::PreProcessor.run(context: context, manifest: manifest).result
-      manifest
+      Ingestions::Strategies::Epub.run!(context:).then do |manifest|
+        Ingestions::PreProcessor.run!(context:, manifest:)
+      end
     end
+
     let!(:text) { Ingestions::Compiler.run(manifest: manifest, context: context).result }
 
     context "when V2" do