Skip to content

[F] Journal editor is allowed to create, read, update, delete projects within journal#3819

Merged
timbot1789 merged 4 commits intomasterfrom
ts/fix-journal-editor-not-editing-issue-project
Mar 7, 2025
Merged

[F] Journal editor is allowed to create, read, update, delete projects within journal#3819
timbot1789 merged 4 commits intomasterfrom
ts/fix-journal-editor-not-editing-issue-project

Conversation

@timbot1789
Copy link
Contributor

@timbot1789 timbot1789 commented Feb 27, 2025

This PR fixes some bugs where journal editors were able to view journal issues, but not the projects within the journal issues (which basically means they couldn't view the issues).

* Remove errant `destroy` verb from authority ability mapping
* Ensure that project creation is explicitly checked and authorized
* Validate creating/updating journal issues for journal editors with
  an existing project
* Correct typo in permission authorizer spec to actually check
  a permission record
@scryptmouse scryptmouse force-pushed the ts/fix-journal-editor-not-editing-issue-project branch from 670abc1 to eba7381 Compare February 27, 2025 22:43
@timbot1789 timbot1789 marked this pull request as ready for review February 28, 2025 00:52
@timbot1789 timbot1789 merged commit 96320ce into master Mar 7, 2025
6 checks passed
@timbot1789 timbot1789 deleted the ts/fix-journal-editor-not-editing-issue-project branch March 7, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants