Merged
Conversation
dananjohnson
force-pushed
the
next
branch
4 times, most recently
from
6593513 to
4bf1786
Compare
dananjohnson
force-pushed
the
feature-theming
branch
from
23bec9d to
141c6bd
Compare
1aurend
force-pushed
the
feature-theming
branch
from
141c6bd to
f968396
Compare
1aurend
force-pushed
the
feature-theming
branch
from
f968396 to
4d33cff
Compare
1aurend
force-pushed
the
feature-theming
branch
from
bdab081 to
b6e07de
Compare
Contributor
Author
|
@dananjohnson this should be ready for an initial review. Is there anything else we wanted to accomplish here? Note: I haven't yet rebased |
dananjohnson
requested changes
Nov 20, 2025
Member
There was a problem hiding this comment.
This is looking good! A few little things:
- Let's adjust the language below the accent color field now, since it's not a text input. Let's just simplify:
Enter a color in an accepted CSS color format. Leave blank to restore default color.Maybe also adjust the others a bit, toOverride the ____ color. Leave blank to restore default color.(Interestingly and semi-related, I noticed that if you type a named color likerebeccapurplein the picker it will convert it for you!) - Can you standardize the focus outline color in the picker to always be the Manifold accent? Sometimes it's blue, sometimes it's green.
- Is it possible for hitting Enter to just close the picker rather than also submitting the form?
Let's leave it there for now. Not everything we wanted, but it's definitely an improvement! Thanks Lauren!
Contributor
Author
Oh neat! I hadn't tried that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.