Move Manifold configuration into anyway config#3953
Open
timbot1789 wants to merge 25 commits intotf/dofrom
Open
Move Manifold configuration into anyway config#3953timbot1789 wants to merge 25 commits intotf/dofrom
timbot1789 wants to merge 25 commits intotf/dofrom
Conversation
- Metadown is often failing to load. Should find an alternative, or fork
- This must be re-added, but has to support internal hostname
- Fetching client public IP is still disabled. This will need to be conditionally supported.
- Improves passing bucket/prefix args - Makes all ACLs public; this may need to be adjusted later
- This should be isolated to just the necessary routes
timbot1789
force-pushed
the
ts/do-anyway-config
branch
5 times, most recently
from
c85d1f9 to
205a864
Compare
- Moved from secrets to env
timbot1789
force-pushed
the
ts/do-anyway-config
branch
from
c04b19b to
15d1533
Compare
- Migration enqueued a job, but runs before good_jobs table is created
timbot1789
force-pushed
the
ts/do-anyway-config
branch
from
15d1533 to
0e551d6
Compare
timfrazee
force-pushed
the
tf/do
branch
2 times, most recently
from
ffb8a42 to
cde1cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 3 main things:
oauth.yml, and it cannot be updated without restarting the app.None of the ENV values have changed location or have otherwise been updated. The only breaking changes or changes that require active intervention are in oauth, which we believe no one is currently using. Other than oauth, this should be a drop-in improvement.