[F] Add external identifiers#3968
Merged
timfrazee merged 3 commits intotf/saml-entitlementsfrom Nov 25, 2025
Merged
Conversation
timbot1789
force-pushed
the
ts/ad-external-identifiers
branch
from
baa1702 to
790493e
Compare
timfrazee
requested changes
Nov 24, 2025
Contributor
timfrazee
left a comment
timfrazee
left a comment
There was a problem hiding this comment.
All in all, looks good. 2 requested changes:
-
Please move the strong params back to
concerns/validation. I know the validation concern is a strange/outdated pattern, but unless we make a decision to move all strong params into their respective controllers, we should follow the existing pattern. -
Please add a unique index to
external_identifiers#identifierin the migration. This will ensure uniqueness if the validations are ever bypassed, and the index will help since we'll often be querying by theidentifierstring.
timfrazee
force-pushed
the
ts/ad-external-identifiers
branch
from
790493e to
7025a33
Compare
Contributor
|
I've made the requested changes above so I can merge this into the saml-entitlements branch and continue work there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves PROJ-3275
This PR adds an
external_identifierattribute to theProjects,ProjectCollections,Journals, andUserGroupsAPIs. This attribute is backed by a database table and ActiveRecord model, but is not exposed as an API endpoint itself.