fix: Use shallow copy before reversing#139
Open
BeiChenStanly wants to merge 1 commit intoManim-Notebook:mainfrom
Open
fix: Use shallow copy before reversing#139BeiChenStanly wants to merge 1 commit intoManim-Notebook:mainfrom
BeiChenStanly wants to merge 1 commit intoManim-Notebook:mainfrom
Conversation
getManimClassAtCursor to avoid mutating cached array
getManimClassAtCursor to avoid mutating cached arraygetManimClassAtCursor
getManimClassAtCursor
Member
|
Nice, thanks for the fix! I will have to fix the GitHub Actions pipeline first, currently it fails with this error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140.
Problem
getManimClassAtCursordirectly callsreverse()on the array returned fromfindAllIn, which modifies the cached array. This causes the array order to change after the first call, leading to incorrect results on subsequent calls.Fix
Replace
manimClasses.reverse().find(...)withmanimClasses.slice().reverse().find(...).slice()creates a shallow copy of the original array.findoperation works on the temporary copy, preserving the original order for future calls.