-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Improve docs and typings for mobject_update_utils
, and add examples for always()
, f_always()
and cycle_animation()
#3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chopan050
wants to merge
12
commits into
ManimCommunity:main
Choose a base branch
from
chopan050:update-utils-typings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les for always and f_always
…pdate-utils-typings
mobject_update_utils
, and add examples for always
and f_always
mobject_update_utils
, and add examples for always()
, f_always()
and cycle_animation()
mobject_update_utils
, and add examples for always()
, f_always()
and cycle_animation()
mobject_update_utils
, and add examples for always()
, f_always()
and cycle_animation()
I'll mark this as a draft for now. PR #4382 was submitted recently, which made me notice some flaws in the current implementation. Back in the time, I didn't stop ignoring MyPy errors for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
always()
,cycle_animation()
andassert_is_mobject_method()
.Parameters
,Returns
andRaises
sections.always()
,f_always()
andcycle_animation()
.MobjectT
TypeVar
in order to get better typings for theMobject
s returned by functions such asalways_redraw()
. For example, if the lambda function insidealways_redraw()
returns aBrace
, theMobject
returned byalways_redraw()
is now recognized as aBrace
and, as such, autocompletion includesBrace
methods and attributes.Callable
s were missing parameter and return types.**kwargs
fromturn_animation_into_updater()
andcycle_animation()
.Links to added or changed documentation pages
https://manimce--3976.org.readthedocs.build/en/3976/reference/manim.animation.updaters.mobject_update_utils.html
Reviewer Checklist