Skip to content

Fix :meth:VMobject.pointwise_become_partial failing when vmobject is self #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

Fix :meth:VMobject.pointwise_become_partial failing when vmobject is self #4193

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c44a33a
Fix Line failing with buff and path_arc
irvanalhaq9 Mar 17, 2025
27741fe
change self to self.copy() in Line, and remove the previous change in…
irvanalhaq9 Mar 29, 2025
488c51b
Revert to first approach: copy points if self is vmobject
irvanalhaq9 May 22, 2025
6dff34d
Add unit test for pointwise_become_partial and Line
irvanalhaq9 May 22, 2025
32fe3af
Merge branch 'main' into fix-line-buff-patharc
irvanalhaq9 May 22, 2025
06ba24e
Merge branch 'main' into fix-line-buff-patharc
chopan050 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manim/mobject/geometry/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def _account_for_buff(self, buff: float) -> None:
if length < 2 * buff:
return
buff_proportion = buff / length
self.pointwise_become_partial(self, buff_proportion, 1 - buff_proportion)
self.pointwise_become_partial(self.copy(), buff_proportion, 1 - buff_proportion)
return

def _set_start_and_end_attrs(
Expand Down