Skip to content

Fix add_points_as_corners not connecting single point to existing path #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Fix add_points_as_corners not connecting single point to existing path #4219

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f955b6
Fix add_points_as_corners not connecting single point to existing path
irvanalhaq9 Apr 16, 2025
682f38c
Refactor add_points_as_corners per review feedback
irvanalhaq9 May 22, 2025
4828615
Merge branch 'main' into fix-add-points-corner-connection
irvanalhaq9 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/mobject/types/vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,8 +1061,8 @@ def add_points_as_corners(self, points: Point3DLike_Array) -> Self:
end_corners = points
self.points = self.points[:-1]
else:
start_corners = points[:-1]
end_corners = points[1:]
start_corners = np.vstack([self.points[-1], points[:-1]])
end_corners = points

nppcc = self.n_points_per_cubic_curve
new_points = np.empty((nppcc * start_corners.shape[0], self.dim))
Expand Down