-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: AnimationGroup with negative z_index #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
09dc7e7
8712c17
26e0fc9
c079386
139c5c7
ccefe48
e4b1d10
3377f6c
23a2df1
c9707f2
6486299
a8458cb
325fa08
a1bb049
0cec802
c4b7a80
ea16d22
9c43ad0
a234ff3
f63ba71
3d029c1
3721fb1
9e74ee7
f124235
b83410a
e54113e
ec501b9
fdb5cb9
2790a70
c1663f1
2f02eb9
047db45
fd8ab62
e73b659
4ddf777
b65b0f2
83d4301
a8c16fb
dea245a
c7ff795
088affd
21fe73b
7ea765a
df36f4f
dba6fa8
a9b65ee
aa0cd4f
7eb8856
d18dc8f
9c9ebf4
04503ad
ded54e4
c887b51
e339a68
d0521fa
fc68c10
2d8d81c
d8a7e55
cb8af6f
b3df1cf
05cc414
48d5a36
b8844b4
0884fea
654068a
2d13eba
d10fb37
1082089
6d65242
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -848,7 +848,18 @@ | |
# as soon as there's one that needs updating of | ||
# some kind per frame, return the list from that | ||
# point forward. | ||
animation_mobjects = [anim.mobject for anim in animations] | ||
|
||
# Imported inside the method to avoid cyclic import | ||
from ..animation.composition import AnimationGroup | ||
|
||
animation_mobjects = [] | ||
for anim in animations: | ||
if isinstance(anim, AnimationGroup): | ||
for sub in anim.animations: | ||
animation_mobjects.append(sub.mobject) | ||
else: | ||
animation_mobjects.append(anim.mobject) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like (without testing it) there might perhaps still be issues with nested groups? Could you try whether assembling the The easiest way to do this is probably by doing something along the lines of for anim in animations:
animation_mobjects.extend(anim.mobject.get_family()) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for review! I am going to fix it in a few days, but I think I will open another PR for this (because there are problems with merge conflicts etc) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I opened new PR. Nested groups now work fine. Please review it |
||
|
||
mobjects = self.get_mobject_family_members() | ||
for i, mob in enumerate(mobjects): | ||
update_possibilities = [ | ||
|
Uh oh!
There was an error while loading. Please reload this page.