Fix for issue 3562 - OpenGL: DecimalNumber set_value #4373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR solves issue #3562.
Further Information and Comments
The issue was inside these lines of the
set_stroke
method of theOpenGLVMobject
class.Each time
set_stroke
was called with thewidth
parameter set to anndarray
, it increased the nesting of the array.This worked fine until the nesting reached a depth of 64 levels, where numpy bailed out.
The suggested change is to check if
width
is anndarray
and if that is the case just use that value, in the other case use the old behaviour.Reviewer Checklist