Rename SceneFileWriter.save_final_image()
to save_image()
#4378
+18
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
SceneFileWriter.save_final_image()
tosave_image()
and fix docstringfix two type annotations in
scene_file_writer.py
make docstrings consistent
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
save_final_image()
was incorrectly named. It is simply saving an image at any point during the scene. It is used incairo_renderer.py
andopengl_renderer.py
to save the last frame ifsave_last_frame
is set in the configuration.Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist