-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bump minimum Python to 3.11 and av to 14.0.1 #4385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
behackl
wants to merge
7
commits into
ManimCommunity:main
Choose a base branch
from
behackl:bump-python-unpin-av
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,788
−2,213
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3129021
chore: bump minimum supported python to 3.11
behackl 9bd7cb8
fix: breaking changes from av upgrade
behackl 201f977
chore: slightly bump minimum required version of av to 14.0.1
behackl 5661789
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4aacc8d
chore: update lockfile
behackl 27e8fc1
Merge branch 'bump-python-unpin-av' of github.com:behackl/manim into …
behackl 205a089
chore: update lockfile again with --upgrade
behackl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,17 +14,15 @@ classifiers = [ | |
"Topic :: Scientific/Engineering", | ||
"Topic :: Multimedia :: Video", | ||
"Topic :: Multimedia :: Graphics", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Programming Language :: Python :: 3.13", | ||
"Natural Language :: English", | ||
] | ||
requires-python = ">=3.9" | ||
requires-python = ">=3.11" | ||
dependencies = [ | ||
"audioop-lts>=0.2.1 ; python_full_version >= '3.13'", | ||
"av>=9.0.0,<14.0.0", | ||
"av>=14.0.1", | ||
"beautifulsoup4>=4.12", | ||
"click>=8.0", | ||
"cloup>=2.0.0", | ||
|
@@ -119,7 +117,7 @@ exclude = [ | |
|
||
[tool.pytest.ini_options] | ||
markers = "slow: Mark the test as slow. Can be skipped with --skip_slow" | ||
addopts = "--no-cov-on-fail --cov=manim --cov-report xml --cov-report term -n auto --dist=loadfile --durations=0" | ||
addopts = "--no-cov-on-fail --cov=manim --cov-report xml --cov-report term -n 10 --dist=loadfile --durations=0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unintended? |
||
|
||
[tool.isort] | ||
profile = "black" | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we should probably also remember to do this for mypy and ruff