-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Typing mobject.py
#4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
henrikmidtiby
wants to merge
19
commits into
ManimCommunity:main
Choose a base branch
from
henrikmidtiby:TypingMobject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Typing mobject.py
#4388
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
af65634
Add type annotations to `mobject.py`
henrikmidtiby 8df3447
More work on type annotations for mobject.py
henrikmidtiby b502836
...
henrikmidtiby 72deed5
Merge branch 'main' into TypingMobject
henrikmidtiby 07e1074
Almost handled all mypy errors
henrikmidtiby 4af521c
Add the mypy error messages to the lines that trigger them
henrikmidtiby 7183ad1
Use typing.cast to avoid some mypy errors, as suggested by JasonGrace…
henrikmidtiby d0e603e
Used the ruff linter
henrikmidtiby acc2ff8
Fixed one typing issue and added the error descriptions to the source…
henrikmidtiby 01f33a0
Set the type of the elements in a VGroup to VMobject
henrikmidtiby baf7e3d
Use typing.cast to handle some specific cases.
henrikmidtiby 6dbfcf8
Code cleaning
henrikmidtiby 62513fd
Updates
henrikmidtiby 37aaa7f
Merge remote-tracking branch 'upstream/main' into TypingMobject
henrikmidtiby 107fbe2
When started to use typing.cast it is needed to import / define certa…
henrikmidtiby 3a2f3b5
Fix bug introduced with the type annotations.
henrikmidtiby c75fbdc
Made it work again
henrikmidtiby 34ecaf7
..
henrikmidtiby 17ca755
Fixed more issues.
henrikmidtiby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These issues can be handled by typing.cast, but I don't think that is the best way to deal with them.