-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add support for negative z-index in AnimationGroup #4389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Merzlikin-Matvey
wants to merge
7
commits into
ManimCommunity:main
Choose a base branch
from
Merzlikin-Matvey:fix_z_index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−1
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
31d94c3
Add support for negative z-index in AnimationGroup
Merzlikin-Matvey 78b2ec5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c66bf55
Refactor animation unpacking logic for clarity
Merzlikin-Matvey c07c89b
Fix unpacking logic to handle Mobject instances correctly
Merzlikin-Matvey 709f51c
Fix mypy check
Merzlikin-Matvey f97131f
Fix tests
Merzlikin-Matvey fa52f04
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+3.97 KB
tests/test_graphical_units/control_data/geometry/negative_z_index_AnimationGroup.npz
Binary file not shown.
Binary file added
BIN
+4.38 KB
tests/test_graphical_units/control_data/geometry/negative_z_index_LaggedStart.npz
Binary file not shown.
Binary file added
BIN
+3.08 KB
...t_graphical_units/control_data/geometry/nested_animation_groups_with_negative_z_index.npz
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, I'd prefer a simpler solution not requiring a new method; something along the lines of the suggestion from my previous review: