Skip to content

fix: infinite recursion caused by accessing color of a highlighted Ta… #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: infinite recursion caused by accessing color of a highlighted Ta… #4435

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47f10d2
fix: infinite recursion caused by accessing color of a highlighted Ta…
BHearron Oct 2, 2025
81379a9
fix: added back needed mypy type ignore
BHearron Oct 3, 2025
6e736a4
Merge branch 'main' into error_4419
henrikmidtiby Oct 23, 2025
bd4545a
Merge branch 'main' into error_4419
henrikmidtiby Oct 23, 2025
5e374b4
Merge branch 'main' into error_4419
henrikmidtiby Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions manim/mobject/geometry/shape_matchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from manim.mobject.mobject import Mobject
from manim.mobject.opengl.opengl_mobject import OpenGLMobject
from manim.mobject.types.vectorized_mobject import VGroup
from manim.utils.color import BLACK, RED, YELLOW, ManimColor, ParsableManimColor
from manim.utils.color import BLACK, RED, YELLOW, ParsableManimColor


class SurroundingRectangle(RoundedRectangle):
Expand Down Expand Up @@ -151,12 +151,6 @@ def set_style(self, fill_opacity: float, **kwargs: Any) -> Self: # type: ignore
)
return self

def get_fill_color(self) -> ManimColor:
# The type of the color property is set to Any using the property decorator
# vectorized_mobject.py#L571
temp_color: ManimColor = self.color
return temp_color


class Cross(VGroup):
"""Creates a cross.
Expand Down